Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MoQ (Media over QUIC) token generation support to the Python Fishjam client by extending the generated OpenAPI client and exposing new convenience methods on FishjamClient.
Changes:
- Introduces new OpenAPI client endpoints for creating MoQ publisher/subscriber tokens.
- Adds
FishjamClient.create_moq_publisher_tokenandFishjamClient.create_moq_subscriber_token. - Adds integration tests covering the new methods and unauthorized behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
fishjam/api/_fishjam_client.py |
Exposes new MoQ token methods on the public client API. |
fishjam/_openapi_client/api/moq/create_moq_publisher_token.py |
Generated OpenAPI endpoint wrapper for publisher token creation. |
fishjam/_openapi_client/api/moq/create_moq_subscriber_token.py |
Generated OpenAPI endpoint wrapper for subscriber token creation. |
fishjam/_openapi_client/api/moq/__init__.py |
Adds the moq API package. |
fishjam/_openapi_client/models/moq_token.py |
Adds the MoqToken response model. |
fishjam/_openapi_client/models/__init__.py |
Exports MoqToken from the OpenAPI models package. |
tests/test_room_api.py |
Adds tests for MoQ token generation and unauthorized errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AHGIJMKLKKZNPJKQR
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documentation impact
Types of changes
not work as expected)